Paths

Table of Contentst

Differential D12308

Further improvements to array comma linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 6 2015, 9:56 PM.

Tags

None

Referenced Files

	F14399607: D12308.diff
	Sun, Dec 22, 5:24 PM

	F14392547: D12308.diff
	Sat, Dec 21, 10:23 PM

	Unknown Object (File)
	Mon, Dec 2, 2:48 AM

	Unknown Object (File)
	Wed, Nov 27, 2:54 AM

	Unknown Object (File)
	Sat, Nov 23, 3:45 AM

	Unknown Object (File)
	Nov 20 2024, 4:58 AM

	Unknown Object (File)
	Nov 18 2024, 6:35 PM

	Unknown Object (File)
	Nov 14 2024, 4:38 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC993166fa497e: Further improvements to array comma linter rule

Summary

Improve the ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR rule to be able to autofix the following code:

array(
  1,
  2,
  3, /* comment */ );

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

Test Failures

Build Status

Buildable 5167
Build 5185: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	8,860 ms	ArcanistXHPASTLinterTestCase::testLinter
	816 ms	ArcanistCSSLintLinterTestCase::testLinter
	119 ms	ArcanistCSSLintLinterTestCase::testVersion
	126 ms	ArcanistChmodLinterTestCase::testLinter
	217 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 46 Passed · 6 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29565.Apr 6 2015, 9:56 PM

joshuaspence retitled this revision from to Further improvements to array comma linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 6 2015, 9:56 PM

Herald added a subscriber: epriestley. · View Herald Transcript

• nagym718 added a task: T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks.Apr 7 2015, 8:03 AM

epriestley removed a task: T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks.Apr 7 2015, 12:25 PM

Works now

joshuaspence updated this object.May 19 2015, 1:24 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

epriestley accepted this revision.May 19 2015, 3:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 3:14 PM

Closed by commit rARC993166fa497e: Further improvements to array comma linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

array-comma.lint-test

10 lines

Diff 29565

src/lint/linter/tests/xhpast/array-comma.lint-test

Loading...