Page MenuHomePhabricator

Improve array comma rule
ClosedPublic

Authored by joshuaspence on Apr 5 2015, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 4:32 PM
Unknown Object (File)
Sat, Feb 8, 3:29 AM
Unknown Object (File)
Sat, Feb 8, 3:29 AM
Unknown Object (File)
Sat, Feb 8, 3:29 AM
Unknown Object (File)
Jan 30 2025, 12:21 PM
Unknown Object (File)
Jan 28 2025, 6:23 AM
Unknown Object (File)
Jan 24 2025, 2:12 AM
Unknown Object (File)
Jan 24 2025, 2:12 AM
Subscribers

Details

Summary

Improve ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR in handling multi-line arrays, see D12280 and D12281 for example. Depends on D12295.

Test Plan

Updated unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 5140
Build 5158: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
1,113 msArcanistPuppetLintLinterTestCase::testLinter
804 msArcanistCSSLintLinterTestCase::testLinter
140 msArcanistCSSLintLinterTestCase::testVersion
137 msArcanistChmodLinterTestCase::testLinter
238 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 46 Passed · 4 Skipped)

Event Timeline

joshuaspence retitled this revision from to Improve array comma rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence updated this object.

I also want to modify this to be able to perform the following fix:

array(
  1,
  2,
-  3,);
+  3,
+);
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:24 PM
This revision was automatically updated to reflect the committed changes.