Paths

Table of Contentst

Differential D12296

Improve array comma rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 12:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 12:21 PM

	Unknown Object (File)
	Tue, Jan 28, 6:23 AM

	Unknown Object (File)
	Fri, Jan 24, 2:12 AM

	Unknown Object (File)
	Fri, Jan 24, 2:12 AM

	Unknown Object (File)
	Fri, Jan 24, 2:12 AM

	Unknown Object (File)
	Tue, Jan 21, 10:27 AM

	Unknown Object (File)
	Sat, Jan 18, 3:39 PM

	Unknown Object (File)
	Dec 20 2024, 9:47 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC3a5ffdc2fdf2: Improve array comma rule

Summary

Improve ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR in handling multi-line arrays, see D12280 and D12281 for example. Depends on D12295.

Test Plan

Updated unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5140
Build 5158: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,113 ms	ArcanistPuppetLintLinterTestCase::testLinter
	804 ms	ArcanistCSSLintLinterTestCase::testLinter
	140 ms	ArcanistCSSLintLinterTestCase::testVersion
	137 ms	ArcanistChmodLinterTestCase::testLinter
	238 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 46 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29499.Apr 5 2015, 12:05 PM

joshuaspence retitled this revision from to Improve array comma rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D12295: Add a method to get the indentation for an XHPASTNode.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 12:05 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence mentioned this in D12281: Fix some odd looking arrays.Apr 5 2015, 12:27 PM

joshuaspence mentioned this in D12280: Fix an odd looking array.

joshuaspence mentioned this in rARC3eacb08273de: Fix an odd looking array.Apr 5 2015, 12:29 PM

joshuaspence mentioned this in rPea376685ae9e: Fix some odd looking arrays.

joshuaspence mentioned this in D12295: Add a method to get the indentation for an XHPASTNode.Apr 5 2015, 1:01 PM

I also want to modify this to be able to perform the following fix:

array(
  1,
  2,
-  3,);
+  3,
+);

epriestley accepted this revision.Apr 6 2015, 1:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2015, 1:24 PM

joshuaspence mentioned this in rPHUd30d314dc8eb: Add a method to get the indentation for an XHPASTNode.Apr 6 2015, 9:44 PM

Closed by commit rARC3a5ffdc2fdf2: Improve array comma rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

18 lines

__tests__/

xhpast/

array-comma.lint-test

24 lines

Diff 29499

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/array-comma.lint-test

Loading...