HomePhabricator

Don't pass data to `jshint` via STDIN

Description

Don't pass data to jshint via STDIN

Summary: Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan: Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7464

Differential Revision: https://secure.phabricator.com/D12298

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Apr 6 2015, 9:26 PM
Reviewer
Blessed Reviewers
Differential Revision
D12298: Don't pass data to `jshint` via STDIN
Parents
rARC637832d06f0e: Fix parsing of PHP compatibility info
Branches
Unknown
Tags
Unknown
Tasks
T7464: jshint.jshintignore not working