Page MenuHomePhabricator

[harbormaster/abort-builds] Support aborting builds in Harbormaster
ClosedPublic

Authored by hach-que on Feb 24 2015, 1:20 AM.
Referenced Files
F14434416: D11870.id33771.diff
Wed, Dec 25, 9:50 PM
Unknown Object (File)
Tue, Dec 24, 5:09 PM
Unknown Object (File)
Tue, Dec 17, 11:58 PM
Unknown Object (File)
Tue, Dec 17, 8:50 PM
Unknown Object (File)
Sun, Dec 15, 12:32 AM
Unknown Object (File)
Sat, Dec 14, 5:44 AM
Unknown Object (File)
Fri, Dec 13, 4:52 AM
Unknown Object (File)
Sun, Dec 8, 7:02 PM
Tokens
"Love" token, awarded by yelirekim."Doubloon" token, awarded by epriestley.

Details

Summary

Ref T1049. This adds support for aborting builds in Harbormaster.

Test Plan

Tested it in production.

Diff Detail

Repository
rP Phabricator
Branch
abort-build
Lint
Lint Warnings
Unit
No Test Coverage
Build Status
Buildable 4625
Build 4639: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Support aborting builds in Harbormaster.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.

Add an explicit abort status

Fix abort all builds button

Add route for buildable action

hach-que retitled this revision from Support aborting builds in Harbormaster to [harbormaster/abort-builds] Support aborting builds in Harbormaster.Jul 1 2015, 5:01 AM
epriestley edited edge metadata.

I think we should rename "STOP" to "PAUSE", in the code and in the UI if it's still there anywhere. The difference between STOP and ABORT is not clear or obvious when reading the code.

Then I think we should consider calling this STOP, to contrast with PAUSE, although I think it's probably clear enough as ABORT.

src/applications/harbormaster/controller/HarbormasterBuildActionController.php
101

Prefer single space after period.

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php
122 ↗(On Diff #32666)

and work will be discarded and builds can not be resumed and must be completely restarted

src/applications/harbormaster/engine/HarbormasterBuildEngine.php
103

Just release the artifacts? Why are you also picking up the other restart side effects?

106

No reason to nest these.

src/applications/harbormaster/storage/build/HarbormasterBuild.php
342

Prevent abort of automatic builds, as other methods now do.

This revision now requires changes to proceed.Aug 8 2015, 6:49 PM

@yelirekim, this is essentially the "cancelled" status you were asking about.

"Cancel" would be another possible name for the "Stop/Abort" operation, but I think stop and abort are probably better terms (and maybe abort is best, since "stopped" sounds weaker than "aborted" to me?)

"stop" / "abort" seems sufficiently self explanatory to me.

sorry didn't read that previous comment thoroughly, pause/abort is even better.

hach-que edited edge metadata.

Rename stop to pause everywhere

hach-que edited edge metadata.

Other requested changes

epriestley edited edge metadata.

Oh, sorry, missed this update. Looks great, thanks!

This revision is now accepted and ready to land.Sep 21 2015, 7:07 PM
This revision was automatically updated to reflect the committed changes.