Ref T1049. This adds support for aborting builds in Harbormaster.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
- Commits
- Restricted Diffusion Commit
rPd5dc4588fce4: [harbormaster/abort-builds] Support aborting builds in Harbormaster
Tested it in production.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7776 Build 8584: [Placeholder Plan] Wait for 30 Seconds Build 8583: arc lint + arc unit
Event Timeline
Comment Actions
I think we should rename "STOP" to "PAUSE", in the code and in the UI if it's still there anywhere. The difference between STOP and ABORT is not clear or obvious when reading the code.
Then I think we should consider calling this STOP, to contrast with PAUSE, although I think it's probably clear enough as ABORT.
| src/applications/harbormaster/controller/HarbormasterBuildActionController.php | ||
|---|---|---|
| 100 | Prefer single space after period. | |
| src/applications/harbormaster/controller/HarbormasterBuildableActionController.php | ||
| 133 | and work will be discarded and builds can not be resumed and must be completely restarted | |
| src/applications/harbormaster/engine/HarbormasterBuildEngine.php | ||
| 102 | Just release the artifacts? Why are you also picking up the other restart side effects? | |
| 105–111 | No reason to nest these. | |
| src/applications/harbormaster/storage/build/HarbormasterBuild.php | ||
| 345 | Prevent abort of automatic builds, as other methods now do. | |
Comment Actions
@yelirekim, this is essentially the "cancelled" status you were asking about.
"Cancel" would be another possible name for the "Stop/Abort" operation, but I think stop and abort are probably better terms (and maybe abort is best, since "stopped" sounds weaker than "aborted" to me?)