run-build-plan] Ensure 'Run Build Plan' fails if a sub-build moves into the aborted status
AbandonedPublic
Actions

Authored by hach-que on Jul 1 2015, 5:10 AM.

Tags

None

Referenced Files

	F19472778: D13509.id32667.diff
	Wed, Jan 7, 12:43 PM

	F19187964: D13509.id32667.diff
	Tue, Dec 16, 7:04 AM

	F18848472: D13509.id.diff
	Oct 30 2025, 4:54 AM

	F18844130: D13509.diff
	Oct 29 2025, 3:19 AM

	F18802539: D13509.id.diff
	Oct 17 2025, 7:25 PM

	F18724339: D13509.id33796.diff
	Sep 30 2025, 3:33 AM

	F18703655: D13509.id.diff
	Sep 28 2025, 4:43 AM

	F18635033: D13509.diff
	Sep 17 2025, 12:26 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

This is split out from D11870 so that D11870 applies cleanly on origin/master. This is the change required to D9807 when both D9807 and D11870 have landed.

This ensures that D11870 correctly fails when a child build moves into the aborted status.

Test Plan

Split out from D11870.

Diff Detail

Repository

rP Phabricator

Branch

hachque-reconstructed

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 7800
Build 8632: [Placeholder Plan] Wait for 30 Seconds
Build 8631: arc lint + arc unit

Event Timeline

hach-que updated this revision to Diff 32667.Jul 1 2015, 5:10 AM

hach-que retitled this revision from to [harbormaster/abort-builds/run-build-plan] Ensure 'Run Build Plan' fails if a sub-build moves into the aborted status.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 1 2015, 5:10 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Rebase

This should obviously just be implemented when upstream implements running or embedding other build plans.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterRunBuildPlanBuildImplementation.php

1 line

Diff 33796

View Options

src/applications/harbormaster/step/HarbormasterRunBuildPlanBuildImplementation.php

[harbormaster/abort-builds/run-build-plan] Ensure 'Run Build Plan' fails if a sub-build moves into the aborted statusAbandonedPublicActions