Page MenuHomePhabricator
Differential D11536

Submit the `arc:generated` property with `arc diff`
AbandonedPublic
Actions

Authored by joshuaspence on Jan 28 2015, 8:53 AM.
Tags
None
Referenced Files
F21260113: D11536.diff
Wed, Jul 8, 2:00 PM
Unknown Object (File)
Tue, Jun 30, 6:45 AM
Unknown Object (File)
Tue, Jun 30, 6:45 AM
Unknown Object (File)
Tue, Jun 30, 6:44 AM
Unknown Object (File)
Fri, Jun 26, 12:32 AM
Unknown Object (File)
Mon, Jun 22, 10:22 PM
Unknown Object (File)
Mon, Jun 22, 10:22 PM
Unknown Object (File)
Mon, Jun 22, 10:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T784: Allow Differential changesets to be marked with various attributes
Summary

Ref T784. When submitting a differential, also submit the arc:generated property so that generated paths are collapsed in the Differential UI. Depends on D11535.

Test Plan

Uploaded a diff and saw generated paths.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4109
Build 4122: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27753.Jan 28 2015, 8:53 AM
joshuaspence retitled this revision from to Submit the `arc:generated` property with `arc diff`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T784: Allow Differential changesets to be marked with various attributes.
joshuaspence added a parent revision: D11535: Allow differential changesets to be marked as generated via diff properties.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2015, 8:53 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 27754.Jan 28 2015, 9:00 AM
joshuaspence edited edge metadata.

Add help text

joshuaspence updated this object.Feb 1 2015, 9:24 PM
joshuaspence updated this revision to Diff 27928.Feb 1 2015, 9:27 PM

Improve help text

joshuaspence updated this revision to Diff 27941.Feb 2 2015, 7:33 AM
  • Remove unrelated changes
  • Set default value for generated-paths
joshuaspence added a child revision: D11537: Allow `ArcanistGeneratedLinter` to respect `generated-paths`.Feb 2 2015, 7:33 AM
joshuaspence updated this revision to Diff 31666.Jun 2 2015, 2:09 PM

Fix example

joshuaspence abandoned this revision.Jun 21 2015, 10:56 PM

See T8095#122313.

Revision Contents
Changeset List

PathSize
src/
workflow/
13 lines

Diff 27753

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Phabricator · Built by Phacility