Page MenuHomePhabricator

`pht`ize a bunch of strings
ClosedPublic

Authored by joshuaspence on Jan 26 2015, 5:01 AM.
Tags
None
Referenced Files
F15311987: D11501.id27660.diff
Thu, Mar 6, 12:47 PM
Unknown Object (File)
Fri, Feb 28, 11:36 AM
Unknown Object (File)
Tue, Feb 25, 5:36 PM
Unknown Object (File)
Tue, Feb 25, 8:16 AM
Unknown Object (File)
Tue, Feb 25, 1:14 AM
Unknown Object (File)
Tue, Feb 25, 12:51 AM
Unknown Object (File)
Tue, Feb 18, 5:16 PM
Unknown Object (File)
Tue, Feb 18, 5:15 PM
Subscribers

Details

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4049
Build 4062: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to `pht`ize a bunch of strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

One technical error.

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
43

Missing a parameter.

This revision is now accepted and ready to land.Jan 26 2015, 3:15 PM
src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
43

Well spotted, I though that the linter was meant to pick this kind of stuff up.

This revision was automatically updated to reflect the committed changes.

A sprintf() linter would be helpful, but we don't have one currently.

We have checks that the parameter is a string, but we don't try to parse the pattern.

(It gets hard with %3$s and stuff, but pht(), qsprintf(), etc., don't support that stuff anyway.)