Page MenuHomePhabricator

`pht`ize a bunch of strings
ClosedPublic

Authored by joshuaspence on Jan 26 2015, 5:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:41 PM
Unknown Object (File)
Feb 25 2024, 2:21 AM
Unknown Object (File)
Feb 14 2024, 8:37 PM
Unknown Object (File)
Feb 11 2024, 6:48 PM
Unknown Object (File)
Jan 27 2024, 9:13 PM
Unknown Object (File)
Jan 17 2024, 11:11 PM
Unknown Object (File)
Jan 9 2024, 11:52 AM
Unknown Object (File)
Dec 23 2023, 6:45 AM
Subscribers

Details

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to `pht`ize a bunch of strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

One technical error.

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
43

Missing a parameter.

This revision is now accepted and ready to land.Jan 26 2015, 3:15 PM
src/lint/engine/ArcanistConfigurationDrivenLintEngine.php
43

Well spotted, I though that the linter was meant to pick this kind of stuff up.

This revision was automatically updated to reflect the committed changes.

A sprintf() linter would be helpful, but we don't have one currently.

We have checks that the parameter is a string, but we don't try to parse the pattern.

(It gets hard with %3$s and stuff, but pht(), qsprintf(), etc., don't support that stuff anyway.)