Paths

Table of Contentst

Differential D11171

Add a linter rule to detect duplicate `case` statements
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 4:11 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6843: Write a linter rule to detect duplicate case statements

Commits

rARCb31e9c0cfee0: Add a linter rule to detect duplicate `case` statements

Summary

Fixes T6843. Adds a linter rule to ArcanistXHPASTLinter to detect duplicate case statements within a switch statement.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3514
Build 3522: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26820.Jan 3 2015, 4:11 AM

joshuaspence retitled this revision from to Add a linter rule to detect duplicate `case` statements.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6843: Write a linter rule to detect duplicate case statements.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 3 2015, 4:11 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Nice!

This revision is now accepted and ready to land.Jan 3 2015, 12:27 PM

Closed by commit rARCb31e9c0cfee0: Add a linter rule to detect duplicate `case` statements (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 7:19 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11194: Fix a duplicate `case` statement.Jan 4 2015, 9:37 AM

joshuaspence mentioned this in rP4e7c10cec54f: Fix a duplicate `case` statement.Jan 4 2015, 9:24 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

41 lines

__tests__/

xhpast/

duplicate-switch-case.lint-test

17 lines

Diff 26820

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/duplicate-switch-case.lint-test

Add a linter rule to detect duplicate `case` statementsClosedPublicActions