HomePhabricator

Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter

Description

Move LINT_NO_COMMIT from ArcanistTextLinter to a new linter

Summary: I don't feel that this linter rule belongs in the ArcanistTextLinter. In fact, this linter rule is quite similar to the rules provided by ArcanistGeneratedLinter and ArcanistNoLintLinter and these classes could possibly be consolidated. I have moved this linter rule to a standalone ArcanistCommitLinter class (which could possibly do additional lints in the future).

Test Plan: Moved existing test cases.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10473

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jan 4 2015, 5:49 AM
Reviewer
Blessed Reviewers
Differential Revision
D10473: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
Parents
rARC821ebcdd0727: `pht`ize some strings
Branches
Unknown
Tags
Unknown