Page MenuHomePhabricator
Differential D11194

Fix a duplicate `case` statement
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 8:03 AM.
Tags
None
Referenced Files
F14444680: D11194.diff
Thu, Dec 26, 11:16 AM
Unknown Object (File)
Sat, Dec 7, 5:45 PM
Unknown Object (File)
Tue, Dec 3, 10:35 PM
Unknown Object (File)
Fri, Nov 29, 9:56 PM
Unknown Object (File)
Thu, Nov 28, 6:27 PM
Unknown Object (File)
Thu, Nov 28, 6:27 PM
Unknown Object (File)
Thu, Nov 28, 6:26 PM
Unknown Object (File)
Thu, Nov 28, 6:26 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4e7c10cec54f: Fix a duplicate `case` statement
Summary

This appears to be a typo, identified by ArcanistXHPASTLinter::LINT_DUPLICATE_SWITCH_CASE (see D11171).

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26867.Jan 4 2015, 8:03 AM
joshuaspence retitled this revision from to Remove a duplicate `case` statement.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 8:03 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jan 4 2015, 9:37 AM
joshuaspence edited edge metadata.
epriestley requested changes to this revision.Jan 4 2015, 4:35 PM
epriestley edited edge metadata.

Nice catch!

I think this should be TYPE_TRUST_EMAILS, though, not removed.

This revision now requires changes to proceed.Jan 4 2015, 4:35 PM
joshuaspence retitled this revision from Remove a duplicate `case` statement to Fix a duplicate `case` statement.Jan 4 2015, 8:41 PM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 26909.Jan 4 2015, 8:42 PM
joshuaspence edited edge metadata.

Change to TYPE_TRUST_EMAILS

epriestley accepted this revision.Jan 4 2015, 9:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 9:18 PM
Closed by commit rP4e7c10cec54f: Fix a duplicate `case` statement (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
editor/
2 lines

Diff 26915

View Options

src/applications/auth/editor/PhabricatorAuthProviderConfigEditor.php

Loading...
Phabricator · Built by Phacility