Page MenuHomePhabricator

Fix a duplicate `case` statement
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 8:03 AM.
Tags
None
Referenced Files
F14027032: D11194.diff
Fri, Nov 8, 4:41 AM
F13998913: D11194.id.diff
Thu, Oct 24, 11:48 AM
F13965912: D11194.id26915.diff
Wed, Oct 16, 5:00 AM
F13963740: D11194.id26867.diff
Tue, Oct 15, 5:38 PM
Unknown Object (File)
Oct 4 2024, 9:02 AM
Unknown Object (File)
Sep 22 2024, 3:55 PM
Unknown Object (File)
Sep 5 2024, 3:58 PM
Unknown Object (File)
Sep 5 2024, 3:58 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4e7c10cec54f: Fix a duplicate `case` statement
Summary

This appears to be a typo, identified by ArcanistXHPASTLinter::LINT_DUPLICATE_SWITCH_CASE (see D11171).

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Remove a duplicate `case` statement.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Nice catch!

I think this should be TYPE_TRUST_EMAILS, though, not removed.

This revision now requires changes to proceed.Jan 4 2015, 4:35 PM
joshuaspence retitled this revision from Remove a duplicate `case` statement to Fix a duplicate `case` statement.Jan 4 2015, 8:41 PM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence edited edge metadata.

Change to TYPE_TRUST_EMAILS

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 9:18 PM
This revision was automatically updated to reflect the committed changes.