Page MenuHomePhabricator

Don't interpret `arc browse .` as a commit
ClosedPublic

Authored by epriestley on Aug 8 2014, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 5:23 PM
Unknown Object (File)
Fri, Mar 8, 10:50 PM
Unknown Object (File)
Mon, Mar 4, 4:53 PM
Unknown Object (File)
Feb 13 2024, 12:21 PM
Unknown Object (File)
Dec 27 2023, 11:16 PM
Unknown Object (File)
Dec 14 2023, 12:05 AM
Unknown Object (File)
Dec 2 2023, 9:36 PM
Unknown Object (File)
Dec 1 2023, 9:33 PM
Subscribers

Details

Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan, avive.
  • Also use git show ... -- to prevent interpretation of the commit argument as a path.

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)
avivey added a reviewer: avivey.

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM
epriestley updated this revision to Diff 24534.

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).