Page MenuHomePhabricator

Don't interpret `arc browse .` as a commit
ClosedPublic

Authored by epriestley on Aug 8 2014, 6:03 PM.
Tags
None
Referenced Files
F21816121: D10197.diff
Tue, Aug 11, 11:16 PM
Unknown Object (File)
Sat, Aug 8, 6:56 PM
Unknown Object (File)
Jul 12 2026, 12:29 AM
Unknown Object (File)
Jul 5 2026, 3:26 PM
Unknown Object (File)
Mar 7 2026, 11:24 PM
Unknown Object (File)
Feb 28 2026, 10:22 PM
Unknown Object (File)
Feb 27 2026, 6:24 PM
Unknown Object (File)
Feb 13 2026, 3:10 PM
Subscribers

Details

Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository
rARC Arcanist
Branch
browsedot
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2115
Build 2119: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan, avive.
  • Also use git show ... -- to prevent interpretation of the commit argument as a path.

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)
avivey added a reviewer: avivey.

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM
epriestley updated this revision to Diff 24534.

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).