Page MenuHomePhabricator

Don't interpret `arc browse .` as a commit
ClosedPublic

Authored by epriestley on Aug 8 2014, 6:03 PM.
Tags
None
Referenced Files
F15481252: D10197.id.diff
Tue, Apr 8, 7:28 PM
F15481212: D10197.id24533.diff
Tue, Apr 8, 7:04 PM
F15480592: D10197.id24531.diff
Tue, Apr 8, 3:06 PM
F15480388: D10197.id24532.diff
Tue, Apr 8, 1:55 PM
F15480221: D10197.id24534.diff
Tue, Apr 8, 12:46 PM
F15476731: D10197.diff
Mon, Apr 7, 9:00 AM
F15469937: D10197.id24532.diff
Fri, Apr 4, 6:18 PM
F15467942: D10197.diff
Thu, Apr 3, 6:33 PM
Subscribers

Details

Summary

Ref T5781. git show . works like HEAD, but that isn't what arc browse . means.

Test Plan

Ran arc browse . with a repository at a published commit.

Diff Detail

Repository
rARC Arcanist
Branch
browsedot
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2115
Build 2119: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't interpret `arc browse .` as a commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan, avive.
  • Also use git show ... -- to prevent interpretation of the commit argument as a path.

this now fails for me:

$ arc browse app
Exception
Command failed with error #128!
COMMAND
git show -s --format='%H' 'app' --

STDOUT
(empty)

STDERR
fatal: bad revision 'app'

(Run with --trace for a full exception trace.)
avivey added a reviewer: avivey.

Yes :)

(I'm still not sure what's the deal with git. It only does that trick for HEAD).

This revision is now accepted and ready to land.Aug 8 2014, 6:15 PM
epriestley updated this revision to Diff 24534.

Closed by commit rARC377eb5d1e0a2 (authored by @epriestley).