Page MenuHomePhabricator
Differential D10057

Use ApplicationTransactions when indexing commit/audit comments
ClosedPublic
Actions

Authored by epriestley on Jul 25 2014, 11:39 PM.
Tags
None
Referenced Files
F18695397: D10057.diff
Sat, Sep 27, 5:27 AM
F18656361: D10057.id24206.diff
Mon, Sep 22, 10:16 PM
F18397816: D10057.id.diff
Aug 29 2025, 2:10 PM
F18381325: D10057.diff
Aug 28 2025, 7:36 PM
F18098662: D10057.id24206.diff
Aug 8 2025, 10:09 PM
F18087216: D10057.id24182.diff
Aug 6 2025, 3:08 AM
F18047761: D10057.id.diff
Aug 3 2025, 1:08 PM
F17953288: D10057.id24206.diff
Aug 1 2025, 2:57 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rPa6698f2ea53c: Use ApplicationTransactions when indexing commit/audit comments
Summary

Ref T4896. Depends on D10056. Moves search indexing to standard infrastructure.

Also, fixes a bug where inline comments would not be indexed.

Test Plan

Used bin/search index ... --trace to view index construction of a commit, saw all the comments and inlines get indexed.

Diff Detail

Repository
rP Phabricator
Branch
audit11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1903
Build 1904: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24182.Jul 25 2014, 11:39 PM
epriestley retitled this revision from to Use ApplicationTransactions when indexing commit/audit comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
epriestley added a parent revision: D10056: Convert Audit comment rendering to standard infrastructure.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 25 2014, 11:39 PM
Harbormaster completed remote builds in B1903: Diff 24182.Jul 25 2014, 11:41 PM
joshuaspence accepted this revision.Jul 28 2014, 12:35 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 28 2014, 12:35 PM
epriestley closed this revision.Jul 28 2014, 10:02 PM
epriestley updated this revision to Diff 24206.

Closed by commit rPa6698f2ea53c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
search/
25 lines
search/
index/
1 line

Diff 24182

View Options

src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
Phabricator · Built by Phacility