Page MenuHomePhabricator
Differential D10019

Hide Audit comment table reads behind an API
ClosedPublic
Actions

Authored by epriestley on Jul 22 2014, 8:01 PM.
Tags
None
Referenced Files
F14413813: D10019.id.diff
Tue, Dec 24, 2:40 PM
F14413812: D10019.id24155.diff
Tue, Dec 24, 2:40 PM
F14413811: D10019.id24079.diff
Tue, Dec 24, 2:40 PM
F14413810: D10019.id24146.diff
Tue, Dec 24, 2:40 PM
F14411402: D10019.diff
Tue, Dec 24, 10:13 AM
Unknown Object (File)
Tue, Dec 10, 6:37 PM
Unknown Object (File)
Sat, Dec 7, 3:47 PM
Unknown Object (File)
Tue, Dec 3, 8:12 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rPdc5c87f74cda: Hide Audit comment table reads behind an API
Summary

Ref T4896. Buries all direct access to the table so we can limit the surface area affected by the migration.

Test Plan
  • Grepped for PhabricatorAuditComment.
  • Grepped for audit_comment.
  • Viewed a bunch of comments.
  • Added a comment.
  • Reindexed a commit.
  • Searched for unique term in new comment.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1886
Build 1887: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24079.Jul 22 2014, 8:01 PM
epriestley retitled this revision from to Hide Audit comment table reads behind an API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 22 2014, 8:01 PM
Harbormaster completed remote builds in B1842: Diff 24079.Jul 22 2014, 8:02 PM
joshuaspence added a parent revision: D10018: Migrate Audit inline comments to new storage.Jul 22 2014, 11:05 PM
joshuaspence accepted this revision.Jul 23 2014, 1:37 PM
joshuaspence edited edge metadata.
joshuaspence added inline comments.
src/applications/audit/storage/PhabricatorAuditComment.php
19

Unused, possibly intentionally for consistency

This revision is now accepted and ready to land.Jul 23 2014, 1:37 PM
epriestley added inline comments.Jul 25 2014, 12:07 AM
src/applications/audit/storage/PhabricatorAuditComment.php
19

Yeah -- this body may swap to a Query which needs $viewer, and passing it now means I don't have to go digging later.

epriestley updated this revision to Diff 24146.Jul 25 2014, 12:07 AM
epriestley edited edge metadata.
  • Rebase, this one doesn't have any PHIDType in it. Linting to double check.
Harbormaster completed remote builds in B1886: Diff 24146.Jul 25 2014, 12:08 AM
epriestley closed this revision.Jul 25 2014, 1:00 AM
epriestley updated this revision to Diff 24155.

Closed by commit rPdc5c87f74cda (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
4 lines
storage/
9 lines
diffusion/
controller/
4 lines
repository/
search/
4 lines

Diff 24146

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditComment.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php

Loading...
Phabricator · Built by Phacility