Improve the handling of `.arclint` files.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 3:25 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC30df78f64cd8: Improve the handling of `.arclint` files.

Summary

Throw a useful error message when an .arclint file is not valid JSON.

Test Plan

Modified an .arclint file to be invalid JSON.

> arc lint
Exception
Parse error on line 24 at column 5: Expected one of: 'EOF', '}', ',', ']'
(Run with --trace for a full exception trace.)

Diff Detail

Repository

rARC Arcanist

Branch

arclint-error

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1317
Build 1317: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23227.Jun 23 2014, 3:25 AM

joshuaspence retitled this revision from to Improve the handling of `.arclint` files..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 3:25 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1317: Diff 23227.Jun 23 2014, 3:26 AM

joshuaspence added a parent revision: D9680: Improve the exception message for JSON parsing exceptions..Jun 23 2014, 3:29 AM

This exception doesn't make it clear that the error is in .arclint, and loses the .arclint path.

You can wrap it in PhutilProxyException to get the best of both worlds, I think.

This revision now requires changes to proceed.Jun 23 2014, 2:10 PM

In D9679#7, @epriestley wrote:

This exception doesn't make it clear that the error is in .arclint, and loses the .arclint path.

You can wrap it in PhutilProxyException to get the best of both worlds, I think.

I agree, but it seems that we don't print the output from proxied exceptions. I'll update the diff and include the output.

Wrap exception in PhutilProxyException

> arc lint
Exception
Expected '.arclint' file to be a valid JSON file, but failed to decode it: /home/joshua/workspace/github.com/phacility/arcanist/.arclint

Harbormaster completed remote builds in B1323: Diff 23236.Jun 23 2014, 3:34 PM

joshuaspence updated this object.Jun 23 2014, 7:14 PM

joshuaspence edited edge metadata.

joshuaspence added a parent revision: D9697: If a `PhutilProxyException` is thrown by Arcanist, print all error messages..