Page MenuHomePhabricator

If a `PhutilProxyException` is thrown by Arcanist, print all error messages.
ClosedPublic

Authored by joshuaspence on Jun 23 2014, 7:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:49 AM
Unknown Object (File)
Sun, Nov 10, 2:05 PM
Unknown Object (File)
Tue, Oct 29, 4:25 PM
Unknown Object (File)
Oct 20 2024, 3:32 AM
Unknown Object (File)
Oct 18 2024, 8:04 PM
Unknown Object (File)
Oct 14 2024, 4:39 PM
Unknown Object (File)
Oct 12 2024, 1:14 AM
Unknown Object (File)
Oct 10 2024, 8:59 AM
Subscribers

Details

Summary

PhutilProxyException provides the capability to nest exceptions. However, if we throw a PhutilProxyException then we currently only display the error message from the top-most exception. Instead, we should print all of the nested exception messages.

Test Plan

Faked an error, saw multiple lines of exception messages.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to If a `PhutilProxyException` is thrown by Arcanist, print all error messages..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence added inline comments.
scripts/arcanist.php
367–368

This is a bit messy and probably should be consolidated.

373

Hmm... In PHP 5.3+ a normal Exception has a getPrevious method too.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 11:21 PM