Throw a useful error message when an .arclint file is not valid JSON.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC30df78f64cd8: Improve the handling of `.arclint` files.
Modified an .arclint file to be invalid JSON.
> arc lint Exception Parse error on line 24 at column 5: Expected one of: 'EOF', '}', ',', ']' (Run with --trace for a full exception trace.)
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arclint-error
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1323 Build 1323: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This exception doesn't make it clear that the error is in .arclint, and loses the .arclint path.
You can wrap it in PhutilProxyException to get the best of both worlds, I think.
Comment Actions
I agree, but it seems that we don't print the output from proxied exceptions. I'll update the diff and include the output.
Comment Actions
> arc lint Exception Expected '.arclint' file to be a valid JSON file, but failed to decode it: /home/joshua/workspace/github.com/phacility/arcanist/.arclint