HomePhabricator

Don't use error context from JSHint in linter messages

Description

Don't use error context from JSHint in linter messages

Summary:
The error context (a.k.a. "original text") as provided by jshint is not very useful and actually causes arc lint to display the lint message incorrectly.

jshint-evidence (579×1 px, 77 KB)

The underlying problem here is that the error context from jshint contains the entire line from the input file rather than just the offending source code.

Test Plan: Ran arc lint -- webroot/rsrc/js/core/behavior-hovercard.js (in rP) and verified that the output looked reasonable.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9675

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jun 23 2014, 12:33 AM
Reviewer
Blessed Reviewers
Differential Revision
D9675: Don't use error context from JSHint in linter messages
Parents
rARC4fd6c99a9331: Only lint files in the working copy with `arc lint --everything`.
Branches
Unknown
Tags
Unknown

Event Timeline