Paths

Table of Contentst

Rebuild `xhpast.exe` with static linkage
ClosedPublic
Actions

Authored by epriestley on Jun 16 2014, 8:30 PM.

Tags

None

Referenced Files

	F13200634: D9581.diff
	Tue, May 14, 2:12 AM

	F13177370: D9581.diff
	Wed, May 8, 7:39 PM

	Unknown Object (File)
	Mon, Apr 29, 2:50 PM

	Unknown Object (File)
	Wed, Apr 24, 10:17 PM

	Unknown Object (File)
	Wed, Apr 24, 6:34 AM

	Unknown Object (File)
	Wed, Apr 24, 6:34 AM

	Unknown Object (File)
	Sat, Apr 20, 7:06 PM

	Unknown Object (File)
	Apr 12 2024, 8:20 AM

View All Files

Subscribers

epriestley

Details

Reviewers

richardvanvelzen

Maniphest Tasks

T5372: Rebuild xhpast.exe with static flags

Commits

rPHU41d51cc2b01d: Rebuild `xhpast.exe` with static linkage

Summary

Fixes T5372.

This thing is like 2.5MB but surely we will never regret checking multi-megabyte binaries into the VCS.

Test Plan

Observed static flags being used during build.
Ran xhpast.exe with some PHP piped into it.
Saw large binary size.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22959.Jun 16 2014, 8:30 PM

epriestley retitled this revision from to Rebuild `xhpast.exe` with static linkage.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: richardvanvelzen.

epriestley added a task: T5372: Rebuild xhpast.exe with static flags.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 16 2014, 8:30 PM

Harbormaster completed remote builds in B1151: Diff 22959.Jun 16 2014, 8:31 PM

It's crazy, but it does work.

windows-xhpast-lint.png (212×667 px, 8 KB)

This revision is now accepted and ready to land.Jun 16 2014, 8:36 PM

Closed by commit rPHU41d51cc2b01d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

xhpast.exe

support/

xhpast/

Makefile

4 lines

Diff 22962

View Options

src/parser/xhpast/bin/xhpast.exe