Paths

Table of Contentst

Differential D9581

Rebuild `xhpast.exe` with static linkage
ClosedPublic
Actions

Authored by epriestley on Jun 16 2014, 8:30 PM.

Details

Reviewers

richardvanvelzen

Maniphest Tasks

T5372: Rebuild xhpast.exe with static flags

Commits

rPHU41d51cc2b01d: Rebuild `xhpast.exe` with static linkage

Summary

Fixes T5372.

This thing is like 2.5MB but surely we will never regret checking multi-megabyte binaries into the VCS.

Test Plan

Observed static flags being used during build.
Ran xhpast.exe with some PHP piped into it.
Saw large binary size.

Diff Detail

Repository

rPHU libphutil

Branch

winbuild1

Lint

Lint Errors

Severity	Location	Code	Message
Error	support/xhpast/Makefile:24	TXT2	Tab Literal

Unit

Tests Passed

Build Status

Buildable 1151
Build 1151: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22959.Jun 16 2014, 8:30 PM

epriestley retitled this revision from to Rebuild `xhpast.exe` with static linkage.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: richardvanvelzen.

epriestley added a task: T5372: Rebuild xhpast.exe with static flags.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 16 2014, 8:30 PM

Harbormaster completed remote builds in B1151: Diff 22959.Jun 16 2014, 8:31 PM

It's crazy, but it does work.

windows-xhpast-lint.png (212×667 px, 8 KB)

This revision is now accepted and ready to land.Jun 16 2014, 8:36 PM

Closed by commit rPHU41d51cc2b01d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

xhpast.exe

support/

xhpast/

Makefile

4 lines

Diff 22959

View Options

src/parser/xhpast/bin/xhpast.exe