Page MenuHomePhabricator

Rebuild `xhpast.exe` with static linkage
ClosedPublic

Authored by epriestley on Jun 16 2014, 8:30 PM.
Tags
None
Referenced Files
F14709585: D9581.diff
Fri, Jan 17, 12:59 PM
Unknown Object (File)
Tue, Jan 14, 11:29 AM
Unknown Object (File)
Sun, Jan 5, 5:18 AM
Unknown Object (File)
Fri, Jan 3, 12:15 AM
Unknown Object (File)
Wed, Dec 25, 11:50 PM
Unknown Object (File)
Dec 9 2024, 2:51 AM
Unknown Object (File)
Dec 9 2024, 12:11 AM
Unknown Object (File)
Dec 8 2024, 3:06 PM
Subscribers

Details

Summary

Fixes T5372.

This thing is like 2.5MB but surely we will never regret checking multi-megabyte binaries into the VCS.

Test Plan
  • Observed static flags being used during build.
  • Ran xhpast.exe with some PHP piped into it.
  • Saw large binary size.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Rebuild `xhpast.exe` with static linkage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: richardvanvelzen.
richardvanvelzen edited edge metadata.

It's crazy, but it does work.

windows-xhpast-lint.png (212×667 px, 8 KB)

This revision is now accepted and ready to land.Jun 16 2014, 8:36 PM
epriestley updated this revision to Diff 22962.

Closed by commit rPHU41d51cc2b01d (authored by @epriestley).