Page MenuHomePhabricator

Rebuild `xhpast.exe` with static linkage
ClosedPublic

Authored by epriestley on Jun 16 2014, 8:30 PM.
Tags
None
Referenced Files
F15302644: D9581.id22962.diff
Wed, Mar 5, 7:13 PM
F15302408: D9581.diff
Wed, Mar 5, 6:55 PM
F15282883: D9581.id.diff
Tue, Mar 4, 3:19 AM
Unknown Object (File)
Tue, Feb 25, 4:58 PM
Unknown Object (File)
Sat, Feb 15, 2:18 AM
Unknown Object (File)
Feb 9 2025, 1:38 PM
Unknown Object (File)
Feb 9 2025, 1:38 PM
Unknown Object (File)
Feb 3 2025, 10:36 AM
Subscribers

Details

Summary

Fixes T5372.

This thing is like 2.5MB but surely we will never regret checking multi-megabyte binaries into the VCS.

Test Plan
  • Observed static flags being used during build.
  • Ran xhpast.exe with some PHP piped into it.
  • Saw large binary size.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Rebuild `xhpast.exe` with static linkage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: richardvanvelzen.
richardvanvelzen edited edge metadata.

It's crazy, but it does work.

windows-xhpast-lint.png (212×667 px, 8 KB)

This revision is now accepted and ready to land.Jun 16 2014, 8:36 PM
epriestley updated this revision to Diff 22962.

Closed by commit rPHU41d51cc2b01d (authored by @epriestley).