Page MenuHomePhabricator
Differential D7960

Made some additional methods of `ArcanistLintEngine` final
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2014, 7:52 AM.
Tags
None
Referenced Files
F14005532: D7960.diff
Sun, Oct 27, 3:02 PM
F13991603: D7960.id.diff
Tue, Oct 22, 11:45 AM
F13969983: D7960.id18007.diff
Thu, Oct 17, 5:03 AM
F13964300: D7960.id.diff
Tue, Oct 15, 8:01 PM
Unknown Object (File)
Oct 5 2024, 3:36 PM
Unknown Object (File)
Sep 20 2024, 2:34 AM
Unknown Object (File)
Sep 19 2024, 12:20 PM
Unknown Object (File)
Sep 19 2024, 12:20 PM
View All Files
Subscribers
aran
epriestley
Korvin
• LegNeato

Details

Reviewers
epriestley
Commits
rARC606380f4bdce: Made some additional methods of `ArcanistLintEngine` final
Summary

To me, it seems that these methods should not be overridden by subclasses

Test Plan

arc lint and arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added a comment.Jan 17 2014, 9:46 PM

(These are all probably fine, I'm just waiting until I have some downtime to review them so I can think through things and catch any issues we might have lurking in prior subclasses.)

joshuaspence added a comment.Jan 24 2014, 7:34 AM

Fair enough... thanks for the update.

btrahan removed a reviewer: Blessed Reviewers.May 7 2014, 5:20 PM
epriestley accepted this revision.May 18 2014, 6:08 PM
epriestley edited edge metadata.
epriestley added a subscriber: • LegNeato.

(+@LegNeato)

These all seem pretty safe to me. I haven't seen users adding much magic to subclasses of LintEngine, either.

This revision is now accepted and ready to land.May 18 2014, 6:08 PM
epriestley closed this revision.May 18 2014, 6:08 PM
epriestley updated this revision to Diff 21815.

Closed by commit rARC606380f4bdce (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
66 lines

Diff 21815

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
Phabricator · Built by Phacility