Page MenuHomePhabricator
Differential D7960

Made some additional methods of `ArcanistLintEngine` final
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2014, 7:52 AM.

Details

Reviewers
epriestley
Commits
rARC606380f4bdce: Made some additional methods of `ArcanistLintEngine` final
Summary

To me, it seems that these methods should not be overridden by subclasses

Test Plan

arc lint and arc unit

Diff Detail

Branch
lint_engine
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley added a comment.Jan 17 2014, 9:46 PM

(These are all probably fine, I'm just waiting until I have some downtime to review them so I can think through things and catch any issues we might have lurking in prior subclasses.)

joshuaspence added a comment.Jan 24 2014, 7:34 AM

Fair enough... thanks for the update.

btrahan removed a reviewer: Blessed Reviewers.May 7 2014, 5:20 PM
epriestley accepted this revision.May 18 2014, 6:08 PM
epriestley edited edge metadata.
epriestley added a subscriber: • LegNeato.

(+@LegNeato)

These all seem pretty safe to me. I haven't seen users adding much magic to subclasses of LintEngine, either.

This revision is now accepted and ready to land.May 18 2014, 6:08 PM
epriestley closed this revision.May 18 2014, 6:08 PM
epriestley updated this revision to Diff 21815.

Closed by commit rARC606380f4bdce (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
66 lines

Diff 18007

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
Phabricator · Built by Phacility