Paths

Table of Contentst

Made some additional methods of `ArcanistLintEngine` final
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2014, 7:52 AM.

Tags

None

Referenced Files

	F14598751: D7960.diff
	Wed, Jan 8, 10:19 PM

	Unknown Object (File)
	Wed, Jan 1, 2:57 PM

	Unknown Object (File)
	Tue, Dec 31, 3:43 AM

	Unknown Object (File)
	Mon, Dec 23, 4:28 AM

	Unknown Object (File)
	Sun, Dec 15, 12:16 PM

	Unknown Object (File)
	Sun, Dec 15, 12:16 PM

	Unknown Object (File)
	Sun, Dec 15, 7:27 AM

	Unknown Object (File)
	Dec 5 2024, 6:44 AM

Subscribers

Details

Reviewers

epriestley

Commits

rARC606380f4bdce: Made some additional methods of `ArcanistLintEngine` final

Summary

To me, it seems that these methods should not be overridden by subclasses

Test Plan

arc lint and arc unit

Diff Detail

Branch

lint_engine

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

(These are all probably fine, I'm just waiting until I have some downtime to review them so I can think through things and catch any issues we might have lurking in prior subclasses.)

Fair enough... thanks for the update.

btrahan removed a reviewer: Blessed Reviewers.May 7 2014, 5:20 PM

(+@LegNeato)

These all seem pretty safe to me. I haven't seen users adding much magic to subclasses of LintEngine, either.

This revision is now accepted and ready to land.May 18 2014, 6:08 PM

Closed by commit rARC606380f4bdce (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistLintEngine.php

66 lines

Diff 18007

View Options

src/lint/engine/ArcanistLintEngine.php

Made some additional methods of `ArcanistLintEngine` finalClosedPublicActions