Page MenuHomePhabricator
Differential D9108

Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.
ClosedPublic
Actions

Authored by joshuaspence on May 13 2014, 9:45 PM.
Tags
None
Referenced Files
F15504489: D9108.id21640.diff
Mon, Apr 14, 6:11 PM
F15499999: D9108.id.diff
Sun, Apr 13, 3:46 PM
F15490850: D9108.id21646.diff
Fri, Apr 11, 9:05 PM
F15489357: D9108.id.diff
Fri, Apr 11, 8:13 AM
F15487104: D9108.diff
Thu, Apr 10, 11:18 AM
F15406386: D9108.diff
Mar 18 2025, 12:29 PM
F15393782: D9108.id21646.diff
Mar 15 2025, 11:06 PM
F15393781: D9108.id21640.diff
Mar 15 2025, 11:06 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4948: Support checkstyle as an output format
Commits
rARCd484b6029505: Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.
Summary

Ref T4948. Move the startDocument code to a renderPreamble function so that, at least theoretically, the renderer can be reused. Otherwise, the only way to reuse the renderer would be to construct a new instance.

Test Plan

Ran arc lint --output xml and verified that the output looked reasonable.

Diff Detail

Repository
rARC Arcanist
Branch
checkstyle
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 442
Build 442: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21640.May 13 2014, 9:45 PM
joshuaspence retitled this revision from to Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2014, 9:45 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B442: Diff 21640.May 13 2014, 9:46 PM
joshuaspence updated this object.May 13 2014, 9:46 PM
joshuaspence edited edge metadata.
joshuaspence added a task: T4948: Support checkstyle as an output format.
epriestley accepted this revision.May 14 2014, 12:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2014, 12:32 AM
epriestley closed this revision.May 14 2014, 12:32 AM
epriestley updated this revision to Diff 21646.

Closed by commit rARCd484b6029505 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 21640

View Options

src/lint/renderer/ArcanistLintCheckstyleXMLRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintRenderer.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility