Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
F14058578: D8360.diff
Sun, Nov 17, 1:11 PM
Unknown Object (File)
Sep 21 2024, 7:51 AM
Unknown Object (File)
Sep 13 2024, 9:35 PM
Unknown Object (File)
Sep 13 2024, 9:35 PM
Unknown Object (File)
Sep 13 2024, 9:34 PM
Unknown Object (File)
Sep 13 2024, 9:34 PM
Unknown Object (File)
Sep 8 2024, 2:36 AM
Unknown Object (File)
Sep 7 2024, 10:18 PM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.