Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
F13150436: D8360.id.diff
Sat, May 4, 3:55 PM
Unknown Object (File)
Sun, Apr 28, 5:27 AM
Unknown Object (File)
Sat, Apr 27, 10:01 PM
Unknown Object (File)
Sat, Apr 20, 6:32 PM
Unknown Object (File)
Mon, Apr 8, 10:44 AM
Unknown Object (File)
Mar 29 2024, 5:03 AM
Unknown Object (File)
Mar 29 2024, 3:53 AM
Unknown Object (File)
Mar 28 2024, 3:00 PM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.