Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 22 2026, 9:23 AM
Unknown Object (File)
Mar 6 2026, 5:28 AM
Unknown Object (File)
Feb 4 2026, 11:38 AM
Unknown Object (File)
Feb 1 2026, 2:46 AM
Unknown Object (File)
Jan 9 2026, 5:09 PM
Unknown Object (File)
Jan 9 2026, 5:07 PM
Unknown Object (File)
Nov 29 2025, 6:12 AM
Unknown Object (File)
Nov 29 2025, 5:15 AM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.