Ref T2222. This is mostly copy/paste. No effect yet.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2222: Implement ApplicationTransactions in Differential
- Commits
- Restricted Diffusion Commit
rP62143b5455e7: Add modern Unit/Lint field support
Looked at fields.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dfield3
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/controller/DifferentialRevisionViewController.php:178 XHP16 TODO Comment Advice src/applications/differential/customfield/DifferentialLintField.php:90 XHP16 TODO Comment - Unit
Tests Passed
Event Timeline
| src/applications/differential/customfield/DifferentialUnitField.php | ||
|---|---|---|
| 186–191 | pht? | |
| src/applications/differential/customfield/DifferentialLintField.php | ||
|---|---|---|
| 37 | These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary. | |