Paths

Table of Contentst

Differential D13919

Fix Owners lookups for the repository root
ClosedPublic
Actions

Authored by epriestley on Aug 17 2015, 12:57 AM.

Details

Reviewers

chad

Maniphest Tasks

T9201: Unhandled Exception ("InvalidArgumentException") on random Differential

Commits

Restricted Diffusion Commit
rPa3393c3ecb92: Fix Owners lookups for the repository root

Summary

Ref T9201. At the root of a repository the current path is null, but the OwnersQuery wants strings.

This could be resolved a couple different ways, but just cast the arguments to strings since that seems reasonable enough.

Test Plan

Browsed root of a repository.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33592.Aug 17 2015, 12:57 AM

epriestley retitled this revision from to Fix Owners lookups for the repository root.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9201: Unhandled Exception ("InvalidArgumentException") on random Differential.

chad accepted this revision.Aug 17 2015, 12:58 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 12:58 AM

epriestley mentioned this in D13918: Fix an issue with Table of Contents construction for copied files.Aug 17 2015, 12:58 AM

Closed by commit rPa3393c3ecb92: Fix Owners lookups for the repository root (authored by epriestley, committed by epriestley). · Explain WhyAug 17 2015, 12:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

2 lines

owners/

query/

PhabricatorOwnersPackageQuery.php

3 lines

Diff 33594

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php