Don't fail lint builds for "advice"; make lint/unit upload failures louder
ClosedPublic
Actions

Authored by epriestley on Jun 25 2015, 2:02 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8657: Harbormaster v1 Errata
T8670: Harbormaster autoplan targets do not always complete

Commits

rARC29839e8c72c5: Don't fail lint builds for "advice"; make lint/unit upload failures louder

Summary

Ref T8670. Ref T8657.

When lint only has advice (no warnings/errors), consider it a "passing" build.
Be a little louder about sendmessage calls failing because this stuff is not totally broken and that makes T8670-related things easier to catch/fix.

Test Plan

Created this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32525.Jun 25 2015, 2:02 PM

epriestley retitled this revision from to Don't fail lint builds for "advice"; make lint/unit upload failures louder.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8670: Harbormaster autoplan targets do not always complete, T8657: Harbormaster v1 Errata.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2015, 2:02 PM

epriestley mentioned this in T8670: Harbormaster autoplan targets do not always complete.Jun 25 2015, 2:03 PM

btrahan accepted this revision.Jun 25 2015, 5:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 25 2015, 5:02 PM

Closed by commit rARC29839e8c72c5: Don't fail lint builds for "advice"; make lint/unit upload failures louder (authored by epriestley, committed by epriestley). · Explain WhyJun 25 2015, 5:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

17 lines

Diff 32538

View Options

src/workflow/ArcanistDiffWorkflow.php

Don't fail lint builds for "advice"; make lint/unit upload failures louderClosedPublicActions