Page MenuHomePhabricator

Add basic Herald support to Calendar
ClosedPublic

Authored by epriestley on Aug 3 2016, 11:46 PM.
Tags
None
Referenced Files
F17866661: D16368.id.diff
Mon, Jul 28, 4:51 AM
F17850333: D16368.diff
Sun, Jul 27, 9:50 AM
F17747515: D16368.id39381.diff
Mon, Jul 21, 10:14 PM
Unknown Object (File)
Jun 18 2025, 4:02 AM
Unknown Object (File)
Jun 17 2025, 9:27 AM
Unknown Object (File)
May 29 2025, 8:47 AM
Unknown Object (File)
May 27 2025, 11:23 AM
Unknown Object (File)
Apr 21 2025, 9:25 PM
Subscribers
None

Details

Summary

Fixes T7939. This doesn't get too fancy, but allows you to write Herald rules against Calendar events.

Test Plan
  • Wrote an "add red flag to events with party in the name" rule.
  • Created a "mundane meeting", didn't get flagged.
  • Created a "cool party", got flagged.
  • Ran rules from the Herald test console.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add basic Herald support to Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 12:03 AM
This revision was automatically updated to reflect the committed changes.