Page MenuHomePhabricator

Add basic Herald support to Calendar
ClosedPublic

Authored by epriestley on Aug 3 2016, 11:46 PM.
Tags
None
Referenced Files
F14058020: D16368.diff
Sun, Nov 17, 8:47 AM
F14041083: D16368.id39367.diff
Mon, Nov 11, 3:48 PM
F14009459: D16368.id39381.diff
Wed, Oct 30, 6:03 PM
F13991035: D16368.id39367.diff
Tue, Oct 22, 8:19 AM
F13989743: D16368.diff
Mon, Oct 21, 10:46 PM
F13986111: D16368.id39381.diff
Mon, Oct 21, 12:41 AM
F13961937: D16368.id39367.diff
Oct 15 2024, 7:08 AM
Unknown Object (File)
Sep 18 2024, 11:58 PM
Subscribers
None

Details

Summary

Fixes T7939. This doesn't get too fancy, but allows you to write Herald rules against Calendar events.

Test Plan
  • Wrote an "add red flag to events with party in the name" rule.
  • Created a "mundane meeting", didn't get flagged.
  • Created a "cool party", got flagged.
  • Ran rules from the Herald test console.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add basic Herald support to Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 12:03 AM
This revision was automatically updated to reflect the committed changes.