Page MenuHomePhabricator
Differential D11682

Fix `pht` method calls
ClosedPublic
Actions

Authored by joshuaspence on Feb 4 2015, 10:42 PM.
Tags
None
Referenced Files
F15543037: D11682.id28217.diff
Fri, Apr 25, 8:14 PM
F15542897: D11682.id.diff
Fri, Apr 25, 7:40 PM
F15486649: D11682.diff
Thu, Apr 10, 8:35 AM
F15486561: D11682.id28117.diff
Thu, Apr 10, 8:10 AM
F15476653: D11682.id28117.diff
Mon, Apr 7, 8:18 AM
F15475723: D11682.id28217.diff
Sun, Apr 6, 10:42 PM
F15467174: D11682.id.diff
Thu, Apr 3, 1:27 PM
F15464213: D11682.diff
Wed, Apr 2, 7:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7046: Add a linter rule for detecting missing variables for `pht`
Commits
rPHU33d38a2f0abe: Fix `pht` method calls
Summary

Ref T7046. This is mainly a proof-of-concept for D11661.

Test Plan

arc lint

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28117.Feb 4 2015, 10:42 PM
joshuaspence retitled this revision from to Fix `pht` method calls.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7046: Add a linter rule for detecting missing variables for `pht`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 4 2015, 10:42 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 9 2015, 2:23 PM
epriestley edited edge metadata.

These are really nice, this linter is great.

This revision is now accepted and ready to land.Feb 9 2015, 2:23 PM
Closed by commit rPHU33d38a2f0abe: Fix `pht` method calls (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 9 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
auth/
2 lines
conduit/
2 lines
parser/
xhpast/
__tests__/
2 lines

Diff 28217

View Options

src/auth/PhutilGoogleAuthAdapter.php

Loading...
View Options

src/conduit/ConduitClient.php

Loading...
View Options

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

Loading...
Phabricator · Built by Phacility