Page MenuHomePhabricator
Differential D11682

Fix `pht` method calls
ClosedPublic
Actions

Authored by joshuaspence on Feb 4 2015, 10:42 PM.
Tags
None
Referenced Files
F13168627: D11682.diff
Tue, May 7, 7:50 AM
Unknown Object (File)
Mon, May 6, 1:51 PM
Unknown Object (File)
Fri, May 3, 7:30 AM
Unknown Object (File)
Tue, Apr 30, 3:54 AM
Unknown Object (File)
Thu, Apr 25, 1:35 AM
Unknown Object (File)
Tue, Apr 16, 2:29 AM
Unknown Object (File)
Sun, Apr 14, 1:14 AM
Unknown Object (File)
Thu, Apr 11, 9:11 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7046: Add a linter rule for detecting missing variables for `pht`
Commits
rPHU33d38a2f0abe: Fix `pht` method calls
Summary

Ref T7046. This is mainly a proof-of-concept for D11661.

Test Plan

arc lint

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28117.Feb 4 2015, 10:42 PM
joshuaspence retitled this revision from to Fix `pht` method calls.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7046: Add a linter rule for detecting missing variables for `pht`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 4 2015, 10:42 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 9 2015, 2:23 PM
epriestley edited edge metadata.

These are really nice, this linter is great.

This revision is now accepted and ready to land.Feb 9 2015, 2:23 PM
Closed by commit rPHU33d38a2f0abe: Fix `pht` method calls (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 9 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
auth/
2 lines
conduit/
2 lines
parser/
xhpast/
__tests__/
2 lines

Diff 28217

View Options

src/auth/PhutilGoogleAuthAdapter.php

Loading...
View Options

src/conduit/ConduitClient.php

Loading...
View Options

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

Loading...
Phabricator · Built by Phacility