Self-explanatory.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCc450fa6c069e: `pht`ize a bunch of strings
Eyeball it.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One technical error.
| src/lint/engine/ArcanistConfigurationDrivenLintEngine.php | ||
|---|---|---|
| 43 | Missing a parameter. | |
| src/lint/engine/ArcanistConfigurationDrivenLintEngine.php | ||
|---|---|---|
| 43 | Well spotted, I though that the linter was meant to pick this kind of stuff up. | |
Comment Actions
A sprintf() linter would be helpful, but we don't have one currently.
We have checks that the parameter is a string, but we don't try to parse the pattern.
(It gets hard with %3$s and stuff, but pht(), qsprintf(), etc., don't support that stuff anyway.)