Differential D10701

Differental - match "Revision ID:" uri value on domain only
ClosedPublic
Actions

Authored by btrahan on Oct 14 2014, 12:00 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T5693: Matching of "Differential Revision" domain names is impossible to debug

Commits

Restricted Diffusion Commit
rPaf4ebc67c66f: Differental - match "Revision ID:" uri value on domain only

Summary

pre-patch, we match on things like https / http and port... just match domains. Fixes T5693.

Test Plan

arc diff -> arc land and the diff was closed correctly

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25695.Oct 14 2014, 12:00 AM

btrahan added a task: T5693: Matching of "Differential Revision" domain names is impossible to debug.

btrahan retitled this revision from to Differental - match "Revision ID:" uri value on domain only.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 14 2014, 12:00 AM

Harbormaster completed remote builds in B2830: Diff 25695.Oct 14 2014, 12:00 AM

epriestley accepted this revision.Oct 14 2014, 12:02 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 14 2014, 12:02 AM

Closed by commit rPaf4ebc67c66f: Differental - match "Revision ID:" uri value on domain only (authored by btrahan, committed by btrahan).Oct 14 2014, 12:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialRevisionIDField.php

12 lines

Diff 25696

View Options

src/applications/differential/customfield/DifferentialRevisionIDField.php

Differental - match "Revision ID:" uri value on domain onlyClosedPublicActions