Page MenuHomePhabricator

Patching another users diff loses track of ownership
Closed, InvalidPublic

Assigned To
Authored By
Jul 9 2014, 2:48 PM
Referenced Files
F175767: Screen_Shot_2014-07-09_at_13.13.51.png
Jul 9 2014, 6:14 PM
F175745: undefined
Jul 9 2014, 5:03 PM
F175747: undefined
Jul 9 2014, 5:03 PM
F175749: undefined
Jul 9 2014, 5:03 PM


Somewhat similar to T4333, but slightly different issue:

When I do a arc patch --nobranch Dxxx && git push there is no record that it was me who actually pushed the diff. Git actually has a special flag for this, the "Signed-Off-By" status line, which is added when doing a git cherry-pick -s operation.

Can we make arc patch detect when the diff is not owned by the person patching and add the "signed off by" status to it?

Event Timeline

shadowhand raised the priority of this task from to Needs Triage.
shadowhand updated the task description. (Show Details)
shadowhand added a project: Arcanist.
shadowhand added subscribers: shadowhand, btrahan, epriestley.

It should be showing your name as the committer, and the author as the author:

undefined (238×484 px, 34 KB)

undefined (185×417 px, 23 KB)

undefined (253×741 px, 21 KB)

Is this not what you're seeing?

@avivey in fact using --format=full is enough to show that:

Screen_Shot_2014-07-09_at_13.13.51.png (54×396 px, 14 KB)

I will leave it to Bob or Evan to decide if this is sufficient, but I think this task can be closed as "invalid".

btrahan claimed this task.

Yeah, this is all working as expected. You become the committer; the original author is preserved as the author. For hosted repositories we also record the pusher, which is the account that performed the push (not necessarily the same as either committer or author, and not recorded in Git metadata).