Page MenuHomePhabricator

No email sent to parent task subscribers when a dependent task has been closed
Closed, ResolvedPublic

Event Timeline

swisspol raised the priority of this task from to Needs Triage.
swisspol updated the task description. (Show Details)
swisspol added a subscriber: swisspol.

Coming from Bugzilla, I have also missed this.

I believe the main problem is that changes of status in dependent tasks are not reflected in the task timeline. The fact that no email notification is sent is a consequence of this.

qgil triaged this task as Normal priority.May 17 2014, 9:16 PM
qgil added a subscriber: aklapper.

It works in practice, but there are a couple of TODOs still around the notifications being too broad. (I think there's also at least one rendering bug here too, but I haven't dug into it yet.)

It works in practice, but there are a couple of TODOs still around the notifications being too broad.

Out of curiosity, are these TODOs listed somewhere (Maniphest tasks, TODOs in some code file, etc)?

(D10088 resolved the "rendering bug" I earlier alluded to, which affected email generation.)

The TODOs I'm referring to are the ones added by D9166 -- you can see them in the review, or in the code here:

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/maniphest/storage/ManiphestTransaction.php;4e9746ed4efb8c151fc47278bd4214ec9a358388$624-631
https://secure.phabricator.com/diffusion/P/browse/master/src/applications/maniphest/editor/ManiphestTransactionEditor.php;4e9746ed4efb8c151fc47278bd4214ec9a358388$268-271

Briefly:

  • We publish feed stories about all of the affected tasks, but the "a blocking task was closed" stories are almost totally redundant with the "this task was closed" story which triggers them. However, we can't currently send notifications without also publishing a feed story, and the notifications are not quite as redundant.
  • We notify users of the "a blocking task was closed" events, even if they were also notified of the triggering "this task was closed" event. In this case (where they're subscribed to the root task), the extra notifications are redundant. However, we can't currently tailor notification delivery (it's not hard, it was just cleaner to leave it out of D9166).