Page MenuHomePhabricator

Improve "unblock task" feed stories
ClosedPublic

Authored by epriestley on Aug 12 2014, 4:22 PM.
Tags
None
Referenced Files
F15510993: D10235.diff
Wed, Apr 16, 11:02 PM
F15506705: D10235.id24627.diff
Tue, Apr 15, 1:26 PM
F15491955: D10235.id24627.diff
Sat, Apr 12, 9:18 AM
F15488729: D10235.id24628.diff
Fri, Apr 11, 2:06 AM
F15481052: D10235.id24628.diff
Tue, Apr 8, 5:51 PM
F15447249: D10235.id24628.diff
Thu, Mar 27, 10:43 PM
F15444967: D10235.id.diff
Thu, Mar 27, 12:04 PM
F15444839: D10235.id24626.diff
Thu, Mar 27, 11:33 AM
Subscribers

Details

Summary

Fixes T5184. Fixes T5008. Three issues with stories/notifications about changing the status of tasks which block other tasks:

Bad Feed Stories

  • Problem: Feed story rendering was confusing (T5184).
  • Solution: fix it to provide context.

Too Many Feed Stories

  • Problem: Feed gets a story for the original task's close ("a closed x"), and a story for each blocked task ("a closed x, a task blocking y").
  • "Solution": Punt. These are redundant in the full feed but not in filtered feeds. Right solution is display-time aggregation. No users have really complained about this.

Too Many Notifications

  • Problem: Users subscribed to both tasks get notified about the clsoe, and also about the unblocked task. These notifications are redundant.
  • "Solution": Punt. This is easy to fix by silencing notifications for the sub-editor, but I'm worried it would be confusing. Users haven't complained. Display-time aggregation might be a better fix.
Test Plan

Screen_Shot_2014-08-12_at_9.22.20_AM.png (95×612 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped