Page MenuHomePhabricator

Make Herald less ambitious about resolving repositories for revisions
ClosedPublic

Authored by epriestley on Mar 20 2014, 12:19 PM.
Tags
None
Referenced Files
F13132637: D8576.diff
Wed, May 1, 8:05 PM
F13130127: D8576.id20370.diff
Wed, May 1, 6:31 AM
Unknown Object (File)
Sun, Apr 28, 9:27 AM
Unknown Object (File)
Sat, Apr 27, 11:22 PM
Unknown Object (File)
Sat, Apr 27, 12:04 PM
Unknown Object (File)
Sat, Apr 20, 6:39 PM
Unknown Object (File)
Fri, Apr 19, 6:22 PM
Unknown Object (File)
Wed, Apr 17, 3:09 PM
Subscribers

Details

Summary

Fixes T4636. If a user manually deletes a "repository" setting from a revision, Herald attempts to resolve it. Instead, Herald should now just trust Differential. Generally, the new logic is:

  • When diffs are created, figure out repository information.
  • When revisions are updated, copy info from diffs.
  • Everywhere else, just trust the revision field.
Test Plan
  • Created revisions.
  • Used Herald to dry-run revisions before and after a manual edit to remove the repository setting.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make Herald less ambitious about resolving repositories for revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2014, 8:16 PM
epriestley updated this revision to Diff 20370.

Closed by commit rP03c6bf0d0916 (authored by @epriestley).