Page MenuHomePhabricator

Guarantee that fields copied from diffs persist on revisions
ClosedPublic

Authored by epriestley on Mar 24 2014, 5:50 PM.
Tags
None
Referenced Files
F18734711: D8610.id.diff
Tue, Sep 30, 11:00 PM
F18702496: D8610.id.diff
Sun, Sep 28, 12:20 AM
F18688671: D8610.diff
Fri, Sep 26, 4:59 PM
F18670447: D8610.id20419.diff
Thu, Sep 25, 12:21 AM
F18107142: D8610.diff
Aug 10 2025, 11:42 PM
Unknown Object (File)
May 19 2025, 7:38 PM
Unknown Object (File)
May 5 2025, 8:21 PM
Unknown Object (File)
Apr 23 2025, 11:07 PM

Details

Summary

Fixes T4636. Currently, we copy fields from the diff to the revision during the external effect phase, but there's no guarantee that we persist the object after this phase.

(In practice, when Herald rules trigger they cause the object to persist on this install, which is why we don't see this issue.)

Instead, move the field copies to the internal phase, where persistence is guaranteed.

Also consolidate some of the diff loading.

Test Plan

Ran arc diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Guarantee that fields copied from diffs persist on revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 8:03 PM
epriestley updated this revision to Diff 20419.

Closed by commit rP2547a222d8b1 (authored by @epriestley).