Paths

Table of Contentst

Differential D7451

Clean up Diffusion branch query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 4:24 AM

	Unknown Object (File)
	Mon, Dec 9, 3:38 AM

	Unknown Object (File)
	Sun, Dec 8, 7:30 AM

	Unknown Object (File)
	Sun, Dec 8, 7:30 AM

	Unknown Object (File)
	Sun, Dec 8, 7:30 AM

	Unknown Object (File)
	Sat, Dec 7, 5:14 PM

	Unknown Object (File)
	Fri, Dec 6, 5:53 PM

	Unknown Object (File)
	Fri, Dec 6, 1:45 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T2716: Consolidate "load commit from name" code

Commits

Restricted Diffusion Commit
rPd1c4b5081cd0: Clean up Diffusion branch query a bit

Summary

Ref T2716.

Serve from DiffusionCommitQuery, not PhabricatorAuditCommitQuery (which should probably die).
Fix logic for limit, which incorrectly failed to display the "Showing %d branches." text.
Clean up things a touch.
I didn't end up actually needing needCommitData(), but left it in there since I think it will be needed soon.
Removed a "TODO" because I don't remember what "etc etc" means.

Test Plan

Looked at branches in several repositories.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 30 2013, 7:35 PM

btrahan added inline comments.

src/applications/diffusion/view/DiffusionBranchTableView.php
64	Added here - https://secure.phabricator.com/rP485b5e5ded5e545f09549f234053e46a5943fb9a - doesn't really shed more light on the mystery though.

haha

iiam

I legitimately have no clue what it might have meant

Closed by commit rPd1c4b5081cd0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryController.php

91 lines

query/

DiffusionCommitQuery.php

38 lines

view/

DiffusionBranchTableView.php

6 lines

repository/

storage/

PhabricatorRepositoryCommit.php

3 lines

Diff 16802

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...