Page MenuHomePhabricator

Clean up Diffusion branch query a bit
ClosedPublic

Authored by epriestley on Oct 30 2013, 3:21 PM.
Tags
None
Referenced Files
F18577997: D7451.diff
Wed, Sep 10, 8:26 PM
F18512856: D7451.diff
Fri, Sep 5, 8:40 AM
F18110758: D7451.id16781.diff
Aug 11 2025, 11:34 PM
F18106805: D7451.diff
Aug 10 2025, 11:23 PM
F18098049: D7451.id16781.diff
Aug 8 2025, 6:08 PM
F18054954: D7451.id16802.diff
Aug 4 2025, 6:51 AM
F17946813: D7451.id.diff
Jul 31 2025, 3:12 PM
F17933971: D7451.diff
Jul 30 2025, 9:47 PM
Subscribers

Details

Summary

Ref T2716.

  • Serve from DiffusionCommitQuery, not PhabricatorAuditCommitQuery (which should probably die).
  • Fix logic for limit, which incorrectly failed to display the "Showing %d branches." text.
  • Clean up things a touch.
  • I didn't end up actually needing needCommitData(), but left it in there since I think it will be needed soon.
  • Removed a "TODO" because I don't remember what "etc etc" means.
Test Plan

Looked at branches in several repositories.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/view/DiffusionBranchTableView.php
64

Added here - https://secure.phabricator.com/rP485b5e5ded5e545f09549f234053e46a5943fb9a - doesn't really shed more light on the mystery though.

haha

iiam

I legitimately have no clue what it might have meant