Page MenuHomePhabricator

Clean up Diffusion branch query a bit
ClosedPublic

Authored by epriestley on Oct 30 2013, 3:21 PM.
Tags
None
Referenced Files
F14004281: D7451.diff
Sat, Oct 26, 5:50 PM
F13985158: D7451.id.diff
Oct 20 2024, 6:29 PM
F13977702: D7451.id16781.diff
Oct 18 2024, 7:39 PM
Unknown Object (File)
Oct 3 2024, 5:01 PM
Unknown Object (File)
Oct 3 2024, 4:57 PM
Unknown Object (File)
Oct 3 2024, 4:56 PM
Unknown Object (File)
Oct 3 2024, 4:54 PM
Unknown Object (File)
Sep 23 2024, 11:23 PM
Subscribers

Details

Summary

Ref T2716.

  • Serve from DiffusionCommitQuery, not PhabricatorAuditCommitQuery (which should probably die).
  • Fix logic for limit, which incorrectly failed to display the "Showing %d branches." text.
  • Clean up things a touch.
  • I didn't end up actually needing needCommitData(), but left it in there since I think it will be needed soon.
  • Removed a "TODO" because I don't remember what "etc etc" means.
Test Plan

Looked at branches in several repositories.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/view/DiffusionBranchTableView.php
64

Added here - https://secure.phabricator.com/rP485b5e5ded5e545f09549f234053e46a5943fb9a - doesn't really shed more light on the mystery though.

haha

iiam

I legitimately have no clue what it might have meant