Paths

Table of Contentst

Differential D7451

Clean up Diffusion branch query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:21 PM.

Tags

None

Referenced Files

	F18798522: D7451.id16781.diff
	Fri, Oct 17, 6:39 AM

	F18755855: D7451.id16781.diff
	Sun, Oct 5, 7:47 AM

	F18745831: D7451.id16802.diff
	Fri, Oct 3, 9:48 AM

	F18734501: D7451.id.diff
	Tue, Sep 30, 10:55 PM

	F18606438: D7451.diff
	Sep 13 2025, 10:19 PM

	F18598772: D7451.diff
	Sep 13 2025, 5:50 AM

	F18589637: D7451.diff
	Sep 12 2025, 3:53 AM

	F18584514: D7451.id.diff
	Sep 11 2025, 12:49 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2716: Consolidate "load commit from name" code

Commits

Restricted Diffusion Commit
rPd1c4b5081cd0: Clean up Diffusion branch query a bit

Summary

Ref T2716.

Serve from DiffusionCommitQuery, not PhabricatorAuditCommitQuery (which should probably die).
Fix logic for limit, which incorrectly failed to display the "Showing %d branches." text.
Clean up things a touch.
I didn't end up actually needing needCommitData(), but left it in there since I think it will be needed soon.
Removed a "TODO" because I don't remember what "etc etc" means.

Test Plan

Looked at branches in several repositories.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 30 2013, 7:35 PM

btrahan added inline comments.

src/applications/diffusion/view/DiffusionBranchTableView.php
64	Added here - https://secure.phabricator.com/rP485b5e5ded5e545f09549f234053e46a5943fb9a - doesn't really shed more light on the mystery though.

haha

iiam

I legitimately have no clue what it might have meant

Closed by commit rPd1c4b5081cd0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryController.php

91 lines

query/

DiffusionCommitQuery.php

38 lines

view/

DiffusionBranchTableView.php

6 lines

repository/

storage/

PhabricatorRepositoryCommit.php

3 lines

Diff 16802

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...