Page MenuHomePhabricator
Differential D7452

Clean up Diffusion tag list query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:33 PM.
Tags
None
Referenced Files
F14059687: D7452.diff
Sun, Nov 17, 9:08 PM
F14047923: D7452.diff
Thu, Nov 14, 5:49 AM
F14036605: D7452.diff
Sun, Nov 10, 11:06 AM
F14020593: D7452.diff
Wed, Nov 6, 12:54 AM
F13955333: D7452.id.diff
Oct 14 2024, 12:59 AM
Unknown Object (File)
Oct 3 2024, 5:08 PM
Unknown Object (File)
Oct 3 2024, 5:05 PM
Unknown Object (File)
Oct 3 2024, 5:04 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2716: Consolidate "load commit from name" code
Commits
Restricted Diffusion Commit
rP25656b311a93: Clean up Diffusion tag list query a bit
Summary
  • Use DiffusionCommitQuery.
  • Use denormalized summary.
  • Use stronger "Importing" test.
Test Plan

Viewed /diffusion/X/ for repos with tags. Saw tags; saw importing commits marked as "Importing" instead of "Unknown".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
42 lines
view/
2 lines
4 lines

Diff 16803

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
Phabricator · Built by Phacility