Page MenuHomePhabricator
Differential D7452

Clean up Diffusion tag list query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:33 PM.
Tags
None
Referenced Files
F18850051: D7452.diff
Oct 30 2025, 2:04 PM
F18833464: D7452.id16803.diff
Oct 26 2025, 3:43 AM
F18777671: D7452.diff
Oct 11 2025, 4:22 AM
F18734504: D7452.id.diff
Sep 30 2025, 10:55 PM
F18512857: D7452.diff
Sep 5 2025, 8:40 AM
F18106806: D7452.diff
Aug 10 2025, 11:23 PM
F18096928: D7452.id16803.diff
Aug 8 2025, 10:09 AM
F18054722: D7452.id16783.diff
Aug 4 2025, 6:36 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2716: Consolidate "load commit from name" code
Commits
Restricted Diffusion Commit
rP25656b311a93: Clean up Diffusion tag list query a bit
Summary
  • Use DiffusionCommitQuery.
  • Use denormalized summary.
  • Use stronger "Importing" test.
Test Plan

Viewed /diffusion/X/ for repos with tags. Saw tags; saw importing commits marked as "Importing" instead of "Unknown".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
42 lines
view/
2 lines
4 lines

Diff 16803

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
Phabricator · Built by Phacility