Page MenuHomePhabricator
Differential D7452

Clean up Diffusion tag list query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:33 PM.
Tags
None
Referenced Files
F15464492: D7452.id16803.diff
Wed, Apr 2, 10:04 AM
F15461386: D7452.id.diff
Tue, Apr 1, 7:58 AM
F15461383: D7452.id16783.diff
Tue, Apr 1, 7:56 AM
F15459762: D7452.diff
Mon, Mar 31, 4:05 PM
F15432321: D7452.diff
Mon, Mar 24, 5:29 PM
F15425694: D7452.id16803.diff
Sun, Mar 23, 5:31 AM
F15420301: D7452.id16783.diff
Fri, Mar 21, 12:55 PM
F15376850: D7452.diff
Thu, Mar 13, 6:09 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2716: Consolidate "load commit from name" code
Commits
Restricted Diffusion Commit
rP25656b311a93: Clean up Diffusion tag list query a bit
Summary
  • Use DiffusionCommitQuery.
  • Use denormalized summary.
  • Use stronger "Importing" test.
Test Plan

Viewed /diffusion/X/ for repos with tags. Saw tags; saw importing commits marked as "Importing" instead of "Unknown".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
42 lines
view/
2 lines
4 lines

Diff 16803

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
Phabricator · Built by Phacility