Page MenuHomePhabricator
Differential D7452

Clean up Diffusion tag list query a bit
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 3:25 AM
Unknown Object (File)
Thu, Feb 27, 3:25 AM
Unknown Object (File)
Wed, Feb 26, 6:33 AM
Unknown Object (File)
Wed, Feb 26, 6:33 AM
Unknown Object (File)
Mon, Feb 17, 2:55 AM
Unknown Object (File)
Mon, Feb 17, 1:46 AM
Unknown Object (File)
Sun, Feb 9, 10:26 AM
Unknown Object (File)
Sun, Feb 9, 10:26 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2716: Consolidate "load commit from name" code
Commits
Restricted Diffusion Commit
rP25656b311a93: Clean up Diffusion tag list query a bit
Summary
  • Use DiffusionCommitQuery.
  • Use denormalized summary.
  • Use stronger "Importing" test.
Test Plan

Viewed /diffusion/X/ for repos with tags. Saw tags; saw importing commits marked as "Importing" instead of "Unknown".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
42 lines
view/
2 lines
4 lines

Diff 16803

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
Phabricator · Built by Phacility