Don't offer personal saved queries in global "Search Scope" settings dropdown
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13405: Support customization of the default global search scope
Commits: rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings…
rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown

Summary

Fixes T13405. We currently offer non-global custom saved queries here, but this doesn't make sense as a global default setting.

Test Plan

Saved a global search query, edited global search settings, no longer saw the non-global query as an option.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Sep 9 2019, 7:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:21 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/applications/settings/setting/PhabricatorSearchScopeSetting.php (3 lines)
M			src/view/page/menu/PhabricatorMainMenuSearchView.php (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49577	bd101d5		Sep 9 2019, 7:16 PM	★	★
Diff 2	49582	63c7302	rP278092974f2f4115cc97172e099ec7fe3941eeb1	Sep 9 2019, 7:21 PM	★	★