Differential D20792

Fix global search scope fatal on 404 page (or other pages with no Application)
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:11 PM.

Tags

None

Referenced Files

	F19283125: D20792.diff
	Tue, Dec 23, 4:32 AM

	F19083050: D20792.id49580.diff
	Dec 2 2025, 12:29 PM

	F19029484: D20792.id.diff
	Nov 24 2025, 6:18 PM

	F19019553: D20792.diff
	Nov 23 2025, 3:04 PM

	F18985193: D20792.id49576.diff
	Nov 17 2025, 12:55 PM

	F18979748: D20792.diff
	Nov 16 2025, 10:52 PM

	F18817940: D20792.id.diff
	Oct 21 2025, 7:38 PM

	F18771486: D20792.id49580.diff
	Oct 8 2025, 7:54 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13405: Support customization of the default global search scope
Commits: rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no…
rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application)

Summary

Ref T13405. Some pages don't have a contextual application.

Test Plan

Viewed 404 page, no more fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 9 2019, 7:11 PM

Harbormaster completed remote builds in B23401: Diff 49576.Sep 9 2019, 7:12 PM

epriestley requested review of this revision.Sep 9 2019, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:18 PM

Closed by commit rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application) (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application).

epriestley added a commit: rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no….Sep 10 2019, 2:11 PM

Revision Contents
Changeset List

Path

Size

src/

view/

page/

menu/

PhabricatorMainMenuSearchView.php

2 lines

Diff 49580

View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Fix global search scope fatal on 404 page (or other pages with no Application)ClosedPublicActions