Page MenuHomePhabricator

Make "No Notifications" setting less broad, and fix a bug with default display behavior
ClosedPublic

Authored by epriestley on Sep 13 2017, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Unknown Object (File)
Tue, Mar 19, 7:27 AM
Unknown Object (File)
Tue, Mar 5, 5:49 PM
Unknown Object (File)
Feb 25 2024, 1:09 PM
Unknown Object (File)
Feb 25 2024, 11:53 AM
Unknown Object (File)
Feb 3 2024, 4:55 PM
Subscribers
None

Details

Summary

Fixes T12979. In D18457, we added a "No Notifications" setting to let users disable the blue and yellow pop-up notifications that alert you when an object has been updated, since some users found them distracting.

However, the change made "do nothing" the default, so all other JX.Notification callsites -- which never pass a preference -- were effectively turned off no matter what your setting was set to. This includes the "Read-Only" mode warning (grey), the "High Security" mode warning (purple), the "timezone" warning, and a few others.

Tweak things a little bit so the setting applies to ONLY blue and yellow ("object you're following was updated" / "this object was updated") notifications, not other types of popup notifications.

Test Plan
  • With notifications on in settings, got blue notifications and "Read-only".
  • With notifications off in settings, got "Read-only" but no blue notifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/notification/builder/PhabricatorNotificationBuilder.php
174–176

Er, I think these are probably not wrong exactly but the old version was clearer, I'll use something more similar.

  • Use slightly clearer construction in NotificationBuilder.
This revision is now accepted and ready to land.Sep 13 2017, 10:09 PM