Page MenuHomePhabricator

Allow more granularity on real-time notifications
ClosedPublic

Authored by chad on Aug 23 2017, 9:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:34 PM
Unknown Object (File)
Sun, Nov 17, 5:50 AM
Unknown Object (File)
Thu, Nov 14, 4:37 PM
Unknown Object (File)
Mon, Nov 11, 1:38 PM
Unknown Object (File)
Sat, Oct 26, 10:51 AM
Unknown Object (File)
Oct 19 2024, 1:08 AM
Unknown Object (File)
Oct 9 2024, 8:11 AM
Unknown Object (File)
Oct 9 2024, 8:11 AM
Subscribers

Details

Summary

Fixes T12792. Expands the Notifications to "web, desktop, both, or none" for real-time notifications in settings.

Test Plan

Test with "test notifications" button, and while logged into two accounts with each of the 4 settings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This will also hide some other notifications (like the timezone notification, and the MFA notification, and the read-only mode notification) but currently none are critical. We could make those notifications punch through this setting eventually.

This revision is now accepted and ready to land.Aug 23 2017, 9:41 PM

live by the blade, die by the blade

Yeah, users who want to turn this off (???) probably won't mind that we turned all the "important system notifications" off too.

I'd like to figure out how to get rid of Timezone stuff. It's been annoying to me, then again I've launched like 50 new installs in the past few weeks testing. System messages maybe should be done another way.

This revision was automatically updated to reflect the committed changes.