Page MenuHomePhabricator

Ask users to sign Legalpad documents before requiring they enroll in MFA
ClosedPublic

Authored by epriestley on Nov 28 2017, 1:05 AM.
Tags
None
Referenced Files
F15471483: D18790.id45099.diff
Sat, Apr 5, 5:19 AM
F15464834: D18790.id45099.diff
Wed, Apr 2, 12:53 PM
F15459671: D18790.id45099.diff
Mon, Mar 31, 3:01 PM
F15458212: D18790.id45084.diff
Sun, Mar 30, 9:44 PM
F15454082: D18790.id.diff
Sat, Mar 29, 4:14 PM
F15452872: D18790.id45084.diff
Sat, Mar 29, 7:52 AM
F15449757: D18790.diff
Fri, Mar 28, 12:03 PM
F15432763: D18790.id45099.diff
Mon, Mar 24, 7:36 PM
Subscribers
None

Details

Summary

Depends on D18789. Ref T13024. See PHI223. Currently, if security.require-multi-factor-auth and Legalpad "Signature Required" documents are both set, it's not possible to survive account registration, since MFA is requiried to sign and signatures are required to add MFA.

Instead, check for signatures before requiring MFA enrollment. This makes logical sense, since it's silly to add MFA if you don't agree to a Terms of Service or whatever.

(Note that if you already have MFA, we prompt for that first, before either of these steps, which also makes sense.)

Test Plan

Configured security.require-multi-factor-auth. Added a signature-required document. Loaded a page as a new user. Went through signature workflow, then through the MFA enrollment workflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable